-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport unzip method in functor typeclass for scala_2.11 #3234
Backport unzip method in functor typeclass for scala_2.11 #3234
Conversation
Codecov Report
@@ Coverage Diff @@
## scala_2.11 #3234 +/- ##
=============================================
+ Coverage 93.5% 93.5% +<.01%
=============================================
Files 382 383 +1
Lines 7147 7149 +2
Branches 194 193 -1
=============================================
+ Hits 6683 6685 +2
Misses 464 464
Continue to review full report at Codecov.
|
If this looks good I can start working on other subtask for #3143 |
d53e268
to
f69d9fb
Compare
I need some help with this error on running
Seems like it's failing for scala_2.11 branch altogether, I'm not very sure how to solve this. |
Have you installed jekyll? It's a Ruby utility, and the right way to install it depends on your OS. |
@rossabaker thank you, now I have, and build error,
ends up with.
|
It suspect it's related to #3218. There was some recent bitrot in jekyll that broke several projects using sbt-microsites, and it doesn't look like any fix was backported to this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but a more active maintainer in the 2.11 BinCompat Hell Era should look at my shrug below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, thanks.
Thank you 😊 |
…3234) * backported unzip method in functor typeclass * fixed nonfunctioning doctest
addresses #3143