Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 follow-up (please don't squash / rebase!) #3219

Merged
merged 3 commits into from
Dec 18, 2019
Merged

2.1.0 follow-up (please don't squash / rebase!) #3219

merged 3 commits into from
Dec 18, 2019

Conversation

travisbrown
Copy link
Contributor

It's on its way to Maven Central, and the release notes are up.

If you're merging this, please only do it with a merge commit! The v2.1.0 release tag points to one of these commits, and if it's not on master we'll have to force-push the tag and 2.1.x branch to clean things up.

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #3219 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3219   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         376      376           
  Lines        7412     7412           
  Branches      192      192           
=======================================
  Hits         6897     6897           
  Misses        515      515
Flag Coverage Δ
#scala_version_212 93.38% <ø> (ø) ⬆️
#scala_version_213 92.82% <ø> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c752844...0b94a01. Read the comment docs.

@travisbrown
Copy link
Contributor Author

Here's the failure:

failing seed for commutativeGroup.associative is 5Cpq4ARTgSX9BY6L-WmlPVyLX_QYb5Fwiq7QbZkXmAN=
[info] - CommutativeGroup[BigDecimal].commutativeGroup.associative *** FAILED ***
[info]   GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
[info]    (Discipline.scala:12)
[info]     Falsified after 54 successful property evaluations.
[info]     Location: (Discipline.scala:12)
[info]     Occurred when passed generated values (
[info]       arg0 = 6.776080345405901E-124,
[info]       arg1 = -3.6430277055389425E-115,
[info]       arg2 = 6.255170362194973E-95
[info]     )
[info]     Label of failing property:
[info]       Expected: 6.255170362194972999963569723012372E-95
[info]   Received: 6.255170362194972999963569723012371E-95

Restarting that job now.

@travisbrown travisbrown merged commit 2c6b1e0 into master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants