Fix a few issues related to bin-compat traits #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @LukaJCB! |
kailuowang
approved these changes
Aug 26, 2019
|
Thanks @travisbrown |
|
This is conceivably source breaking, but it would take some really weird code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3007 and #3008 for some context. This PR does three (related) things:
AllSyntaxandAllInstancestraits up to date on the latestBinCompatlevels, fixing The kitchen sink import should match the slightly smaller kitchen sink imports #3007 and some similar problems.AllInstancesBinCompatclass that works the same way as the existingAllSyntaxBinCompat.AllXBinCompatNtraits public again (undoing one small piece of Make bincompat and prioritization traits package-private #3003). This is necessary to support some common usage (see Decide how public-facing instance traits should be #3008 for details), but that might be something we decide to stop supporting in the future.