Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add par functions for UnorderedTraverse. #2931

Conversation

takayahilton
Copy link
Contributor

@takayahilton takayahilton commented Jul 5, 2019

Added parUnordered.

* add par functions for UnorderedTraverse
* add tests for UnorderedTravers
@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #2931 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2931      +/-   ##
==========================================
+ Coverage   94.03%   94.03%   +<.01%     
==========================================
  Files         370      370              
  Lines        7038     7046       +8     
  Branches      186      188       +2     
==========================================
+ Hits         6618     6626       +8     
  Misses        420      420
Impacted Files Coverage Δ
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/parallel.scala 82.75% <100%> (+2.75%) ⬆️
core/src/main/scala/cats/Parallel.scala 90.62% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e053e28...520f370. Read the comment docs.

@mberndt123
Copy link
Contributor

@LukaJCB,

Hey, I just implemented the same thing. Unfortunately I only noticed this PR after submitting my PR #2946. However my PR also includes parUnorderedFlatTraverse and parUnorderedFlatSequence, so if you think we need those, you can merge my PR instead. If you feel they're not needed, you can just close my PR.

@kailuowang
Copy link
Contributor

close since #2946 is merged.

@kailuowang kailuowang closed this Aug 5, 2019
@takayahilton takayahilton deleted the add-par-unordered-traversable branch August 6, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants