Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for 2.0.0-M2 and 2.0.0-M3 #2873

Merged
merged 6 commits into from
Jun 11, 2019

Conversation

travisbrown
Copy link
Contributor

The usual. That's a bunch of new contributors.

r? @rossabaker

@travisbrown travisbrown requested a review from kailuowang June 1, 2019 20:07
@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #2873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2873   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         368      368           
  Lines        6948     6948           
  Branches      308      308           
=======================================
  Hits         6546     6546           
  Misses        402      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a4cd4...6a05250. Read the comment docs.

LukaJCB
LukaJCB previously approved these changes Jun 1, 2019
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that some of the authors are not correct. E.g. #2833. I will use the release note script to generate one and compare when I get some time next week

@travisbrown
Copy link
Contributor Author

@kailuowang What do you mean? Do we not include doc / README editors here? I just ran git log v2.0.0-M1...v2.0.0-M3 and added these manually from there.

@kailuowang
Copy link
Contributor

I was referring to the authors mentioned in changes

This was referenced Jun 3, 2019
@kailuowang
Copy link
Contributor

@travisbrown sorry I accidently just updated the PR directly, I meant to create a PR to your branch but github throws me a 404 when I tried. Then I clicked the wrong button...
For the most part I used this script which requires some work on github beforehand, i.e. setting milestone and labels for all merged PRs.
I removed trivial README updates from the release notes as well as corrected some author names. authors given bygit logs are not accurate for squash merged PRs.

CHANGES.md Outdated
* [#2827](https://github.com/typelevel/cats/pull/2827) In Apply.semigroup test replace ` ListWrapper` with `Option` by @kailuowang


### 1 bug fixes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is automated but can we at least fix the pluralization?

CHANGES.md Outdated
* [#2821](https://github.com/typelevel/cats/pull/2821) removing unused resolver by @kailuowang


### 2 test improvments
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the spelling.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
kailuowang
kailuowang previously approved these changes Jun 5, 2019
@kailuowang
Copy link
Contributor

sort of related. #2881 is submitted to update the Process document.

@kailuowang
Copy link
Contributor

@LukaJCB will you have time to take another quick look?

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kailuowang kailuowang merged commit 50b88fd into typelevel:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants