-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Ops and replaced them with forwarders. #2766
Conversation
is it possible to add some benchmark here to verify the performance? |
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 95.34% 95.29% -0.06%
==========================================
Files 363 363
Lines 6785 6818 +33
Branches 283 303 +20
==========================================
+ Hits 6469 6497 +28
- Misses 316 321 +5
Continue to review full report at Codecov.
|
There's a remaining use of Ops in https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/syntax/hash.scala. Afterwards I think you should be able to delete https://github.com/typelevel/cats/blob/master/macros/src/main/scala/cats/macros/Ops.scala and remove machinist from build.sbt. |
|
||
} | ||
|
||
private[arrow] object FunctionKMacros { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't simply remove this code. we need to create two versions of it, one for scala 2.x with the current implementation and another with the new scala3 implementation. Like in this example
https://github.com/typelevel/cats/tree/master/core/src/main/scala-2.13%2B/cats/compat
we created two versions of cats.compat.SortedSet
import cats.data.{EitherK, Tuple2K} | ||
|
||
>>>>>>> 60c2fe6336f1e4dff1cd7d7eb839c19f83778b63 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge error?
Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePR
and commit the changed files, if any, before submitting.