Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Ops and replaced them with forwarders. #2766

Closed
wants to merge 5 commits into from

Conversation

drdozer
Copy link
Contributor

@drdozer drdozer commented Mar 28, 2019

Thank you for contributing to Cats!

This is a kind reminder to run sbt prePR and commit the changed files, if any, before submitting.

@kailuowang
Copy link
Contributor

kailuowang commented Mar 29, 2019

is it possible to add some benchmark here to verify the performance?

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #2766 into master will decrease coverage by 0.05%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   95.34%   95.29%   -0.06%     
==========================================
  Files         363      363              
  Lines        6785     6818      +33     
  Branches      283      303      +20     
==========================================
+ Hits         6469     6497      +28     
- Misses        316      321       +5
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/partialOrder.scala 100% <100%> (+100%) ⬆️
core/src/main/scala/cats/syntax/order.scala 100% <100%> (+100%) ⬆️
core/src/main/scala/cats/syntax/semigroup.scala 50% <33.33%> (+50%) ⬆️
core/src/main/scala/cats/syntax/eq.scala 40% <50%> (+40%) ⬆️
core/src/main/scala/cats/syntax/group.scala 75% <66.66%> (+75%) ⬆️
alleycats-core/src/main/scala/alleycats/Zero.scala 0% <0%> (ø) ⬆️
laws/src/main/scala/cats/laws/FoldableLaws.scala 100% <0%> (ø) ⬆️
...lleycats-core/src/main/scala/alleycats/Empty.scala 0% <0%> (ø) ⬆️
alleycats-core/src/main/scala/alleycats/One.scala 0% <0%> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyList.scala 100% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1205af2...4a98735. Read the comment docs.

@smarter
Copy link
Contributor

smarter commented Mar 29, 2019

There's a remaining use of Ops in https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/syntax/hash.scala. Afterwards I think you should be able to delete https://github.com/typelevel/cats/blob/master/macros/src/main/scala/cats/macros/Ops.scala and remove machinist from build.sbt.


}

private[arrow] object FunctionKMacros {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't simply remove this code. we need to create two versions of it, one for scala 2.x with the current implementation and another with the new scala3 implementation. Like in this example
https://github.com/typelevel/cats/tree/master/core/src/main/scala-2.13%2B/cats/compat
we created two versions of cats.compat.SortedSet

import cats.data.{EitherK, Tuple2K}

>>>>>>> 60c2fe6336f1e4dff1cd7d7eb839c19f83778b63
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge error?

@smarter
Copy link
Contributor

smarter commented Jun 30, 2019

I've made updated PRs for the machinist part: #2925 and the FunctionK part (using a different solution proposed on the issue): #2926, so this PR can be closed.

@kailuowang kailuowang closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants