Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findM to Foldable #2365

Closed
wants to merge 2 commits into from
Closed

Conversation

KentShikama
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2365 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   95.01%   94.73%   -0.28%     
==========================================
  Files         349      349              
  Lines        5997     5982      -15     
  Branches      223      215       -8     
==========================================
- Hits         5698     5667      -31     
- Misses        299      315      +16
Impacted Files Coverage Δ
core/src/main/scala/cats/Foldable.scala 100% <100%> (ø) ⬆️
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <0%> (-36.67%) ⬇️
core/src/main/scala/cats/syntax/either.scala 85% <0%> (-14.17%) ⬇️
.../src/main/scala/cats/data/RepresentableStore.scala 83.33% <0%> (-4.17%) ⬇️
core/src/main/scala/cats/data/IorT.scala 97.74% <0%> (-0.05%) ⬇️
core/src/main/scala/cats/Eval.scala 98.79% <0%> (-0.05%) ⬇️
core/src/main/scala/cats/data/Ior.scala 98.47% <0%> (-0.02%) ⬇️
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a59eb6...271da59. Read the comment docs.

Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t add this to Foldable without breaking binary compatibility very seriously.

We only break package private and sealed binary compatibility since no one using scala should have subclassed those.

Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put this on a binary compatible shim as we have done in other cases.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @johnynek said, please add this as a syntax extension instead of a method on a type class :)

We can add these to the type class when we next break binary compatibility, i.e. 2.0.

@KentShikama
Copy link
Author

Closing for #2421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants