-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add findM to Foldable #2365
Add findM to Foldable #2365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
- Coverage 95.01% 94.73% -0.28%
==========================================
Files 349 349
Lines 5997 5982 -15
Branches 223 215 -8
==========================================
- Hits 5698 5667 -31
- Misses 299 315 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can’t add this to Foldable without breaking binary compatibility very seriously.
We only break package private and sealed binary compatibility since no one using scala should have subclassed those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put this on a binary compatible shim as we have done in other cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @johnynek said, please add this as a syntax extension instead of a method on a type class :)
We can add these to the type class when we next break binary compatibility, i.e. 2.0.
Closing for #2421 |
No description provided.