-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Data Type list fix #1497
Docs Data Type list fix #1497
Conversation
Current coverage is 91.93% (diff: 100%)@@ master #1497 diff @@
==========================================
Files 244 244
Lines 3621 3621
Methods 3502 3498 -4
Messages 0 0
Branches 119 123 +4
==========================================
Hits 3329 3329
Misses 292 292
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I am thinking can you try
{% if x.section == 'data' and x.title != page.title %}
instead of hard coding the title?
closing and reopen to trigger the build again. |
72904e4
to
34eb2b4
Compare
Great suggestion of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
At present, the documentation page for data types has a list of all the available data types: in this bullet list, the "Data Types" page itself is listed (see attached image).
This PR fixes the generation of the data type bullet list, so that "Data Type" is no longer listed as a valid data type.