Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Free/State to data package? #785

Closed
ceedubs opened this issue Jan 7, 2016 · 4 comments
Closed

Move Free/State to data package? #785

ceedubs opened this issue Jan 7, 2016 · 4 comments

Comments

@ceedubs
Copy link
Contributor

ceedubs commented Jan 7, 2016

Currently there are separate (but small) packages for free and state. This is because up until #760 they were in their own separate modules. Now that they are within core, should we drop the free/state from their package name and move them to the data package to be more consistent with other types like WriterT?

I'm not sure data is a particularly meaningful package name for some of these types, but that's probably a tangential issue (if it's an "issue" at all).

@dwijnand
Copy link
Contributor

dwijnand commented Jan 7, 2016

👍 from me, for either cats.data or cats.

@travisbrown
Copy link
Contributor

👍, and I'm fine with having them all directly under cats.data.

@ceedubs
Copy link
Contributor Author

ceedubs commented May 5, 2016

Update: Since #990 was merged, this no longer applies to free.

@ceedubs
Copy link
Contributor Author

ceedubs commented May 11, 2016

Oops I just realized that State has already been moved to the data package. Looks like it's time to close this out.

@ceedubs ceedubs closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants