Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should WriterT be in a separate module? #573

Closed
ceedubs opened this issue Oct 16, 2015 · 8 comments
Closed

Should WriterT be in a separate module? #573

ceedubs opened this issue Oct 16, 2015 · 8 comments

Comments

@ceedubs
Copy link
Contributor

ceedubs commented Oct 16, 2015

Recently WriterT was added to the core module (in the data package). Should it go into a separate module?

Currently StateT lives in a separate state module. Mostly this is because State depends on Free for trampolining. However, as far as I know, having a separate state module hasn't led to any complaints. It makes me wonder if WriterT should also be in a separate module, as it's not essential to "core" Cats functionality. I suspect many people will use Cats without finding themselves reaching for WriterT.

@aryairani
Copy link
Contributor

having a separate state module hasn't led to any complaints.

Do we have a sense of how many people are using the state module?

@ceedubs
Copy link
Contributor Author

ceedubs commented Oct 16, 2015

@refried no, I have no idea. I suspect very few.

@dwijnand
Copy link
Contributor

dwijnand commented Jan 6, 2016

Now that #765 is merged, the state and free modules are now dead, which might be of interest for this issue.

@ceedubs
Copy link
Contributor Author

ceedubs commented Jan 6, 2016

@dwijnand good point. If StateT is in core, it probably makes sense for WriterT to be in there too. A PR would be welcome from anyone who is interested in doing this work.

edit - ignore this comment. I forgot that WriterT was already in core when I wrote it...

@lukiano
Copy link

lukiano commented Jan 7, 2016

will there be a MonadTell / MonadListen for WriterT?

@ceedubs
Copy link
Contributor Author

ceedubs commented Jan 7, 2016

@lukiano there probably should be. Feel free to create a separate issue for that if it's something you would use.

@DavidGregory084
Copy link
Member

@ceedubs I'm not sure what the objective of this issue is anymore now that there are no separate modules; especially with reference to #785. Should this be closed?

@ceedubs
Copy link
Contributor Author

ceedubs commented Jan 7, 2016

@DavidGregory084 ah thanks. I was confused when I wrote https://github.com/non/cats/issues/573#issuecomment-169318605 (see the edit I just added). I'll close this out.

@ceedubs ceedubs closed this as completed Jan 7, 2016
@ceedubs ceedubs removed the ready label Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants