Skip to content

Commit

Permalink
Okay so Parallel is using DummyImplicit; so should we
Browse files Browse the repository at this point in the history
  • Loading branch information
djspiewak committed Sep 9, 2019
1 parent 3efcda1 commit 8bb92f9
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions laws/src/main/scala/cats/laws/NonEmptyParallelLaws.scala
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ object NonEmptyParallelLaws {
type Aux[M[_], F0[_]] = NonEmptyParallelLaws[M] { type F[A] = F0[A]; val P: NonEmptyParallel.Aux[M, F0] }

def apply[M[_]](implicit ev: NonEmptyParallel[M]): NonEmptyParallelLaws.Aux[M, ev.F] =
Aux[M, ev.F](ev)
apply[M, ev.F](ev, implicitly)

def Aux[M[_], F[_]](implicit ev: NonEmptyParallel.Aux[M, F]): NonEmptyParallelLaws.Aux[M, F] =
def apply[M[_], F[_]](implicit ev: NonEmptyParallel.Aux[M, F], D: DummyImplicit): NonEmptyParallelLaws.Aux[M, F] =
new NonEmptyParallelLaws[M] { val P: ev.type = ev }
}
4 changes: 2 additions & 2 deletions laws/src/main/scala/cats/laws/ParallelLaws.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ object ParallelLaws {
type Aux[M[_], F0[_]] = ParallelLaws[M] { type F[A] = F0[A]; val P: Parallel.Aux[M, F0] }

def apply[M[_]](implicit ev: Parallel[M]): ParallelLaws.Aux[M, ev.F] =
Aux[M, ev.F](ev)
apply[M, ev.F](ev, implicitly)

def Aux[M[_], F[_]](implicit ev: Parallel.Aux[M, F]): ParallelLaws.Aux[M, F] =
def apply[M[_], F[_]](implicit ev: Parallel.Aux[M, F], D: DummyImplicit): ParallelLaws.Aux[M, F] =
new ParallelLaws[M] { val P: ev.type = ev }
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ object NonEmptyParallelTests {
type Aux[M[_], F0[_]] = NonEmptyParallelTests[M] { type F[A] = F0[A]; val laws: NonEmptyParallelLaws.Aux[M, F0] }

def apply[M[_]](implicit ev: NonEmptyParallel[M]): NonEmptyParallelTests.Aux[M, ev.F] =
Aux[M, ev.F](ev)
apply[M, ev.F](ev, implicitly)

def Aux[M[_], F[_]](implicit ev: NonEmptyParallel.Aux[M, F]): NonEmptyParallelTests.Aux[M, F] =
def apply[M[_], F[_]](implicit ev: NonEmptyParallel.Aux[M, F], D: DummyImplicit): NonEmptyParallelTests.Aux[M, F] =
new NonEmptyParallelTests[M] { val laws = NonEmptyParallelLaws[M] }
}
4 changes: 2 additions & 2 deletions laws/src/main/scala/cats/laws/discipline/ParallelTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ object ParallelTests {
type Aux[M[_], F0[_]] = ParallelTests[M] { type F[A] = F0[A]; val laws: ParallelLaws.Aux[M, F0] }

def apply[M[_]](implicit ev: Parallel[M]): ParallelTests.Aux[M, ev.F] =
Aux[M, ev.F](ev)
apply[M, ev.F](ev, implicitly)

def Aux[M[_], F[_]](implicit ev: Parallel.Aux[M, F]): ParallelTests.Aux[M, F] =
def apply[M[_], F[_]](implicit ev: Parallel.Aux[M, F], D: DummyImplicit): ParallelTests.Aux[M, F] =
new ParallelTests[M] { val laws = ParallelLaws[M] }
}
2 changes: 1 addition & 1 deletion tests/src/test/scala/cats/tests/ParallelSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ class ParallelSuite extends CatsSuite with ApplicativeErrorForEitherTest with Sc
checkAll("NonEmptyParallel[NonEmptyList]", NonEmptyParallelTests[NonEmptyList].nonEmptyParallel[Int, String])

// TODO this doesn't infer?
checkAll("Parallel[NonEmptyStream]", ParallelTests.Aux[NonEmptyStream, OneAnd[ZipStream, *]].parallel[Int, String])
checkAll("Parallel[NonEmptyStream]", ParallelTests[NonEmptyStream, OneAnd[ZipStream, *]].parallel[Int, String])

checkAll("Parallel[Id]", ParallelTests[Id].parallel[Int, String])

Expand Down

0 comments on commit 8bb92f9

Please sign in to comment.