Merge pull request #606 from ceedubs/validated-orElse

Remove EE >: E constraint from Validated.orElse
typelevel · Nov 8, 2015 · 65db253 · 65db253
2 parents d4125a5 + 73ed7f7
commit 65db253
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/core/src/main/scala/cats/data/Validated.scala b/core/src/main/scala/cats/data/Validated.scala
@@ -50,8 +50,11 @@ sealed abstract class Validated[+E, +A] extends Product with Serializable {
   /**
    * Return this if it is Valid, or else fall back to the given default.
    */
-  def orElse[EE >: E, AA >: A](default: => Validated[EE,AA]): Validated[EE,AA] =
-    fold(_ => default, _ => this)
+  def orElse[EE, AA >: A](default: => Validated[EE,AA]): Validated[EE,AA] =
+    this match {
+      case v @ Valid(_) => v
+      case Invalid(_) => default
+    }
 
   /**
    * Converts the value to an Either[E,A]