Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted improvements #90

Merged
merged 4 commits into from
Jan 24, 2018
Merged

Assorted improvements #90

merged 4 commits into from
Jan 24, 2018

Conversation

dfreeman
Copy link
Member

Took a little time after lunch to clean up some things I noticed this morning:

  • our Serve subclass now calls the superclass's onInterrupt so the build shuts down cleanly on ctrl-c
  • the temporary output directory moved to the system tempdir (watching/rebuilds still work just fine locally) to avoid needing to configure exclusions for .e-c-ts in the project dir
  • there should be no more thrashing rebuilds between the tsc watcher and the ember-cli watcher:
    • ember serve-ts now waits for the initial compilation to complete before building the rest of the app, so the compiled JS is already present in the output directory when the first build runs
    • switching from exclude to include in the default tsconfig.json gets tsc to ignore the contents of tmp (though this does make things a little more interesting with addons/module unification down the line)
  • the emitted app URL (Serving on http://localhost:4200/) should be correct now

Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXCELLENT.

@chriskrycho chriskrycho merged commit a666892 into typed-ember:fast-incremental-compiler Jan 24, 2018
@dfreeman dfreeman deleted the fast-incremental-compiler branch January 24, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants