Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlift updatePathsForAddon from the blueprints package #1537

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

dfreeman
Copy link
Member

It turns out the default blueprint relied on the fact that we were adding ember-cli-typescript-blueprints to import an updatePathsForAddon utility function. Since that's no longer a safe assumption, I've just airlifted that function directly into this codebase.

I also updated a couple places in the docs that assumed the presence of ember-cli-typescript-blueprints by default.

@dfreeman dfreeman added the bug label Oct 26, 2022
@dfreeman dfreeman requested a review from chriskrycho October 26, 2022 11:17
@@ -122,7 +121,8 @@
"typescript": "4.5.5"
},
"resolutions": {
"hawk": "7"
"hawk": "7",
"ember-cli-typescript": "link:."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, is this a standard Yarn pattern for self-resolution? I hadn't seen it before.

On reading the lock file changes, how does this impact consumers (if at all)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, is this a standard Yarn pattern for self-resolution?

I'm not sure if it's "standard" but it's definitely one I've used in a few places. In principle it could blow up on us in a future where we make big breaking changes here and our dependencies that rely on ember-cli-typescript aren't ready for that but are having it forced on them anyway. Since I don't think we're super likely to be making any changes like that, though... ¯\_(ツ)_/¯

On reading the lock file changes, how does this impact consumers (if at all)?

I don't think it should impact consumers at all, since resolutions only apply in your project's own package.json, not your dependencies'.

@chriskrycho chriskrycho merged commit f57c8b0 into master Oct 26, 2022
@chriskrycho chriskrycho deleted the missing-blueprints-util branch October 26, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants