Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include @types/ember__destroyable when running the default blueprint #1526

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Include @types/ember__destroyable when running the default blueprint #1526

merged 2 commits into from
Oct 25, 2022

Conversation

bertdeblock
Copy link
Contributor

Closes #1497.

chriskrycho
chriskrycho approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@chriskrycho
Copy link
Member

chriskrycho commented Sep 25, 2022 •
edited
Loading

Note: this may fail CI because of smoke tests. If so, this fix should be straightforward: just update the fixtures.

@bertdeblock bertdeblock mentioned this pull request Sep 28, 2022
Closed
@chriskrycho
Copy link
Member

I've updated this with the changes from master, and it passes locally, so I've pushed that to this branch and it should go green on everything but the ember-cli checks. Once that's true, I'll merge this!

@chriskrycho chriskrycho merged commit 48eccbf into typed-ember:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newly installed app doesn't get @types/ember__destroyable
2 participants
@bertdeblock @chriskrycho