Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-use-before-define lint violation in environment.d.ts #1521

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Jul 28, 2022

Running linting in a brand new Ember addon with TypeScript with the ESLint no-use-before-define lint rule enabled:

~/Development/my-test-addon main * yarn eslint --ext=.ts,.js .

~/Development/my-test-addon/tests/dummy/app/config/environment.d.ts
  1:16  error  'config' was used before it was defined                                         no-use-before-define

This is an easy and harmless fix to avoid this lint violation for anyone using this lint rule.

@bmish bmish changed the title Fix no-use-before-define linting violation in environment.d.ts Fix no-use-before-define lint violation in environment.d.ts Jul 28, 2022
@chriskrycho
Copy link
Member

Totally missed this, sorry @bmish! Very behind on my GitHub notifications (and I expect the same is true for other maintainers). Do you mind rebasing and pushing to get GH actions running?

@chriskrycho
Copy link
Member

Never mind; this change is trivial and good. 👍🏼

@chriskrycho chriskrycho merged commit 057c674 into typed-ember:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants