Improved compiler throughput (see microsoft#2329).

tylerbrawl · Jan 9, 2023 · 34d5bd4 · 34d5bd4
1 parent 9d7a8b6
commit 34d5bd4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/stl/inc/ostream b/stl/inc/ostream
@@ -1304,11 +1304,13 @@ void println(ostream& _Ostr, const format_string<_Types...> _Fmt, _Types&&... _A
     _STD _Print_impl<true>(_Ostr, _Fmt, _STD forward<_Types>(_Args)...);
 }
 
-_EXPORT_STD inline void vprint_unicode(ostream& _Ostr, const string_view _Fmt_str, const format_args _Fmt_args) {
+_EXPORT_STD template <int = 0> // improves throughput, see GH-2329
+void vprint_unicode(ostream& _Ostr, const string_view _Fmt_str, const format_args _Fmt_args) {
     _STD _Vprint_unicode_impl<false>(_Ostr, _Fmt_str, _Fmt_args);
 }
 
-_EXPORT_STD inline void vprint_nonunicode(ostream& _Ostr, const string_view _Fmt_str, const format_args _Fmt_args) {
+_EXPORT_STD template <int = 0> // improves throughput, see GH-2329
+void vprint_nonunicode(ostream& _Ostr, const string_view _Fmt_str, const format_args _Fmt_args) {
     _STD _Vprint_nonunicode_impl<false>(_Ostr, _Fmt_str, _Fmt_args);
 }
 #else // ^^^ _CPPRTTI / !_CPPRTTI vvv

diff --git a/stl/inc/print b/stl/inc/print
@@ -176,20 +176,24 @@ void println(const format_string<_Types...> _Fmt, _Types&&... _Args) {
     _STD println(stdout, _Fmt, _STD forward<_Types>(_Args)...);
 }
 
-_EXPORT_STD inline void vprint_unicode(FILE* const _Stream, const string_view _Fmt_str, const format_args _Fmt_args) {
+_EXPORT_STD template <int = 0> // improves throughput, see GH-2329
+void vprint_unicode(FILE* const _Stream, const string_view _Fmt_str, const format_args _Fmt_args) {
     _STD _Vprint_unicode_impl<false>(_Stream, _Fmt_str, _Fmt_args);
 }
 
-_EXPORT_STD inline void vprint_unicode(const string_view _Fmt_str, const format_args _Fmt_args) {
+_EXPORT_STD template <int = 0> // improves throughput, see GH-2329
+void vprint_unicode(const string_view _Fmt_str, const format_args _Fmt_args) {
     _STD vprint_unicode(stdout, _Fmt_str, _Fmt_args);
 }
 
-_EXPORT_STD inline void vprint_nonunicode(
+_EXPORT_STD template <int = 0> // improves throughput, see GH-2329
+void vprint_nonunicode(
     FILE* const _Stream, const string_view _Fmt_str, const format_args _Fmt_args) {
     _STD _Vprint_nonunicode_impl<false>(_Stream, _Fmt_str, _Fmt_args);
 }
 
-_EXPORT_STD inline void vprint_nonunicode(const string_view _Fmt_str, const format_args _Fmt_args) {
+_EXPORT_STD template <int = 0> // improves throughput, see GH-2329
+void vprint_nonunicode(const string_view _Fmt_str, const format_args _Fmt_args) {
     _STD vprint_nonunicode(stdout, _Fmt_str, _Fmt_args);
 }