feat: evm multi chain signer #7

ljankovic-txfusion · 2024-11-12T15:44:03Z

No description provided.

ltyu

first pass. i like the progress!

ltyu · 2024-11-12T16:29:08Z

typescript/cli/cli.ts

@@ -69,6 +71,7 @@ try {
    .command(submitCommand)
    .command(validatorCommand)
    .command(warpCommand)
+    .command(strategyCommand)


can we alphabetize this?

ltyu · 2024-11-12T16:31:36Z

typescript/cli/src/commands/strategy.ts

+      description:
+        'Type of submitter (jsonRpc, impersonatedAccount, gnosisSafe, gnosisSafeTxBuilder)',
+    },
+    safeAddress: {


since it looks like we prompt these based on the type, do we need this?

You are right!

ltyu · 2024-11-12T16:39:34Z

typescript/cli/src/commands/strategy.ts

+      false,
+      'The path to output a Strategy Config JSON or YAML file.',
+    ),
+    type: {


do we need this? users are prompted to select a set, but in this case we also allow users to enter their own type (i believe this will fail for unsupported submitter types)?

i suggest we just stick to 1: prompt users to select

ltyu · 2024-11-12T16:44:39Z

typescript/cli/src/commands/strategy.ts

+  },
+};
+
+function isValidPrivateKey(privateKey: string): boolean {


could be useful in other places. consider moving to utils

ltyu · 2024-11-12T16:47:15Z

typescript/cli/src/commands/strategy.ts

+        );
+        submitter.chain = chain;
+
+        if (type === TxSubmitterType.GNOSIS_TX_BUILDER) {


do we need this? already inside of case TxSubmitterType.GNOSIS_TX_BUILDER

On lines 139 & 140 we handle gnosis safe and tx builder(uses 1.0 as the default version):

case TxSubmitterType.GNOSIS_SAFE: case TxSubmitterType.GNOSIS_TX_BUILDER:

ltyu · 2024-11-12T17:37:45Z

typescript/cli/src/context/context.ts

@@ -17,13 +17,16 @@ import {
 import { isHttpsUrl, isNullish, rootLogger } from '@hyperlane-xyz/utils';

 import { isSignCommand } from '../commands/signCommands.js';
+import { readDefaultStrategyConfig } from '../config/strategy.js';
+// import { readDefaultStrategyConfig } from '../config/strategy.js';


ltyu · 2024-11-12T17:55:16Z

typescript/cli/src/context/strategies/chain/MultiChainHandler.ts

+        'warp',
+      );
+    } else {
+      console.log(`Using warp route deployment config at ${configPath}`);


can we use the logger here instead?

ltyu · 2024-11-12T17:56:21Z

typescript/cli/src/context/strategies/chain/MultiChainHandler.ts

+    }
+
+    const warpRouteConfig = readYamlOrJson(configPath);
+    assert(


no need to assert because if the file doesn't exists, readYamlOrJson will throw

ltyu · 2024-11-12T17:57:54Z

typescript/cli/src/config/strategy.ts

+  filePath: string,
+): Promise<ChainSubmissionStrategy> {
+  const config = readYamlOrJson(filePath);
+  assert(config, `No default strategy config found at ${filePath}`);


no need to assert, readYamlOrJson will throw

ltyu · 2024-11-12T18:21:22Z

typescript/cli/src/context/strategies/submitter/JsonRpcStrategy.ts

+
+    return (
+      submitter?.privateKey ??
+      (await password({


ljankovic-txfusion · 2024-11-13T09:36:27Z

typescript/cli/src/deploy/warp.ts

@@ -155,7 +157,7 @@ export async function runWarpRouteDeploy({

  await writeDeploymentArtifacts(warpCoreConfig, context);

-  await completeDeploy(context, 'warp', initialBalances, userAddress, chains);
+  await completeDeploy(context, 'warp', initialBalances, null, chains!);


User address will be determined by the signer associated to one of the chains in the prepareDeploy and completeDeploy functions

ljankovic-txfusion · 2024-11-13T09:37:31Z

typescript/cli/src/send/transfer.ts

-      'Select the destination chain',
-    );
-  }
-


This logic is outsourced to signerMiddleware

ljankovic-txfusion · 2024-11-13T09:39:50Z

typescript/cli/src/send/message.ts

-      'Select the destination chain',
-    );
-  }
-


This logic is outsourced to signerMiddleware -> user is prompted to select origin & destination (if not provided in CLI) before reaching sendTestMessage function call

… file

…ocolSigner implementation for flexible cross-chain signer configuration and management

…ntext multiprovider

…ane-xyz#4942) ### Description - Retrieve gas payment by origin, interchain_gas_paymaster and sequence - Add Sealevel to Scraper in E2E Ethereum and Sealevel tests ### Related issues - Contributes into hyperlane-xyz#4271 ### Backward compatibility Yes (after backfill of origin, destination, interchain_gas_paymaster) ### Testing E2E Ethereum and Sealevel tests (including scraping Sealevel) --------- Co-authored-by: Danil Nemirovsky <[email protected]>

### Description Upgrade Scraper ### Related issues - Contributes into hyperlane-xyz#4271 ### Backward compatibility Yes ### Testing E2E Ethereum and Sealevel test Co-authored-by: Danil Nemirovsky <[email protected]>

### Description Add index to cursor table so than Scraper starts quickly ### Backward compatibility Yes ### Testing Manual Co-authored-by: Danil Nemirovsky <[email protected]>

…Module

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @hyperlane-xyz/[email protected] ### Minor Changes - aa1ea9a: updates the warp deployment config schema to be closer to the ica routing schema - 323f0f1: Add ICAs management in core apply command ### Patch Changes - 455a897: Fix a bug where it would try to relay the incorrect message from a transaction that dispatches multiple messages. - Updated dependencies [2054f4f] - Updated dependencies [a96448f] - Updated dependencies [170a0fc] - Updated dependencies [9a09afc] - Updated dependencies [24784af] - Updated dependencies [3e8dd70] - Updated dependencies [aa1ea9a] - Updated dependencies [665a7b8] - Updated dependencies [f0b98fd] - Updated dependencies [ff9e8a7] - Updated dependencies [97c1f80] - Updated dependencies [323f0f1] - Updated dependencies [6115709] - @hyperlane-xyz/[email protected] - @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ### Minor Changes - 2054f4f: Require Sealevel native transfers to cover the rent of the recipient - a96448f: Add logic into SDK to enable warp route unenrollment - 170a0fc: Add `createHookUpdateTxs()` to `WarpModule.update()` such that it 1) deploys a hook for a warp route _without_ an existing hook, or 2) update an existing hook. - 9a09afc: Deploy to appchain, treasure, zklink. - 24784af: Introduce GcpValidator for retrieving announcements, checkpoints and metadata for a Validator posting to a GCP bucket. Uses GcpStorageWrapper for bucket operations. - 3e8dd70: Update validators for boba, duckchain, unichain, vana, bsquared, superseed. Update oort's own validator. Update blockpi's viction validator. Adad luganodes/dsrv to flame validator set. - aa1ea9a: updates the warp deployment config schema to be closer to the ica routing schema - f0b98fd: Updated the derivation logic to enable ICA ISM metdata building from on chain data to enable self relaying of ICA messages - ff9e8a7: Added a getter to derive ATA payer accounts on Sealevel warp routes - 97c1f80: Implement Sealevel IGP quoting - 323f0f1: Add ICAs management in core apply command - 6115709: Deploy to swell & lumiaprism. Parallelise router enrollment in HyperlaneRouterDeployer. ### Patch Changes - 665a7b8: Added decimal consistency checks to the Token checker - @hyperlane-xyz/[email protected] - @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ### Patch Changes - @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ### Patch Changes - Updated dependencies [2054f4f] - Updated dependencies [a96448f] - Updated dependencies [170a0fc] - Updated dependencies [9a09afc] - Updated dependencies [24784af] - Updated dependencies [3e8dd70] - Updated dependencies [aa1ea9a] - Updated dependencies [665a7b8] - Updated dependencies [f0b98fd] - Updated dependencies [ff9e8a7] - Updated dependencies [97c1f80] - Updated dependencies [323f0f1] - Updated dependencies [6115709] - @hyperlane-xyz/[email protected] - @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ### Patch Changes - Updated dependencies [2054f4f] - Updated dependencies [a96448f] - Updated dependencies [170a0fc] - Updated dependencies [9a09afc] - Updated dependencies [24784af] - Updated dependencies [3e8dd70] - Updated dependencies [aa1ea9a] - Updated dependencies [665a7b8] - Updated dependencies [f0b98fd] - Updated dependencies [ff9e8a7] - Updated dependencies [97c1f80] - Updated dependencies [323f0f1] - Updated dependencies [6115709] - @hyperlane-xyz/[email protected] - @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ### Minor Changes - 1ca8574: add USDC, USDT, cbBTC and ETH zeronetwork warp routes support in infra - 323f0f1: Add ICAs management in core apply command ### Patch Changes - Updated dependencies [2054f4f] - Updated dependencies [a96448f] - Updated dependencies [170a0fc] - Updated dependencies [9a09afc] - Updated dependencies [24784af] - Updated dependencies [3e8dd70] - Updated dependencies [aa1ea9a] - Updated dependencies [665a7b8] - Updated dependencies [f0b98fd] - Updated dependencies [ff9e8a7] - Updated dependencies [97c1f80] - Updated dependencies [323f0f1] - Updated dependencies [6115709] - @hyperlane-xyz/[email protected] - @hyperlane-xyz/[email protected] - @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] ## @hyperlane-xyz/[email protected] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### Description Mostly mentions the new Rust workspace split ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing None

### Description - extend `GovernTransactionReader` to parse warp route txs ### Drive-by changes - use latest reg version in packages ### Related issues  ### Backward compatibility  ### Testing  --------- Signed-off-by: pbio <[email protected]>

### Description - Combine remaining schema and types files - Rename TokenConfig related types and utilities for clarity. E.g. `CollateralConfig` to `CollateralTokenConfig`. - De-dupe some Ownable types - Export more schemas from SDK ### Backward compatibility No

### Description Remove redundant words in comment Signed-off-by: avoidaway <[email protected]>

### Description * Add Sealevel testnets to domain table ### Drive-by changes * Sort domain alphabetically ### Related issues - Contributes into hyperlane-xyz#4271 ### Backward compatibility Yes ### Testing Local run of init db --------- Co-authored-by: Danil Nemirovsky <[email protected]>

### Description This PR adds hook deployment within a warp config ### Related issues  ### Backward compatibility Yes ### Testing Manual/Unit Tests

…to feat/key-command

…ter props

ljankovic-txfusion added 8 commits November 7, 2024 16:39

feat: Singe/MultiVM signer strategy

ba0d6ea

feat: Deployment strategies & refactoring

2bf349b

fix: e2e test working

9c43d1c

chore: add comments & minor refactoring

3602abd

chore: minor fixes

ce81b48

Merge remote-tracking branch 'origin-root/main'

ff2b4c9

Merge remote-tracking branch 'origin-root/main'

af97d7f

perf: removed unused code and refactoring

e4839a1

ltyu reviewed Nov 12, 2024

View reviewed changes

ljankovic-txfusion commented Nov 13, 2024

View reviewed changes

feat: masked pk, refactoring

4abd806

mshojaei-txfusion force-pushed the main branch from ff2b4c9 to 1866635 Compare November 14, 2024 10:10

ljankovic-txfusion added 4 commits November 14, 2024 14:21

feat: MultiChainHandler support to extract chains from WarpCoreConfig…

188dced

… file

chore: refactoring & adding comments

0b92c68

Merge remote-tracking branch 'origin/main' into feat/key-command

ea205dc

feat: relay command chain resolver strategy & refactoring

ac6d5c1

ljankovic-txfusion changed the title ~~Feat/strategy command~~ feat: evm multi chain signer Nov 15, 2024

ljankovic-txfusion added 11 commits November 18, 2024 13:57

feat: Signer strategy based on chain's protocol/tech stack

925621c

chore: minor refactoring

a0ea88b

Merge remote-tracking branch 'origin/main' into feat/key-command

f030f23

add: strategy types for submitter

52efa81

chore: following naming conventions & comments

12679af

feat: requiresKey options on strategy read command

b7d439b

chore: revert MessageOptionsArgTypes origin & destination optionality

24b9d7a

feat: strategy init chain agnostic

60a2ae2

feat: logging private key source

884db14

chore: MultiProtocolSignerOptions refactor

2cc7ca4

docs(changeset): Added strategy management CLI commands and MultiProt…

d7326a6

…ocolSigner implementation for flexible cross-chain signer configuration and management

ljankovic-txfusion and others added 30 commits November 25, 2024 17:53

fix: passed key used for setting signer

e61baff

Merge remote-tracking branch 'origin/main' into feat/key-command

2d08d1e

fix: update getWarpCoreConfigOrExit import on MultiChainResolver

92115c0

Merge remote-tracking branch 'origin-root/main' into feat/key-command

0c8dc01

fix: no-unused-vars linting issues

ccc7df6

minor: remove catch unused param

bdf0107

fix: read multiProtocolSigner from sginer middleware on warp init

21758af

refactor: standardize signer address handling on context

38310f8

feat(cli): Add 'check' command to SIGN_COMMANDS and use signer for co…

6e437c7

…ntext multiprovider

fix: handle warp check as a sign command on signer strategies

4820623

fix: handle warp read and warp check as sign command temporary

3146e93

chore: fix typo

fa2b0e8

Merge branch 'main' into feat/key-command

80533e1

chore: modify type of signer on context

4e3b65c

fix: remove unused variables

e5a63c9

Merge branch 'main' into feat/key-command

7bf044f

feat: Upgrade Scraper (hyperlane-xyz#4960)

aeb2596

### Description Upgrade Scraper ### Related issues - Contributes into hyperlane-xyz#4271 ### Backward compatibility Yes ### Testing E2E Ethereum and Sealevel test Co-authored-by: Danil Nemirovsky <[email protected]>

fix: resolve chais when there is remoteIcaRouters on core apply

96322c5

fix: Add index to cursor table (hyperlane-xyz#4961)

d043909

### Description Add index to cursor table so than Scraper starts quickly ### Backward compatibility Yes ### Testing Manual Co-authored-by: Danil Nemirovsky <[email protected]>

refactor(resolver): enhance core apply chains resolution with EvmCore…

1eb69e9

…Module

chore: update the Rust readme (hyperlane-xyz#4968)

08cf6ac

### Description Mostly mentions the new Rust workspace split ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing None

chore: remove redundant words in comment (hyperlane-xyz#4970)

57c43f1

### Description Remove redundant words in comment Signed-off-by: avoidaway <[email protected]>

feat: Add deploy hook with config to warp deploy (hyperlane-xyz#4977)

bb44f9b

### Description This PR adds hook deployment within a warp config ### Related issues  ### Backward compatibility Yes ### Testing Manual/Unit Tests

Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…

676f22a

…to feat/key-command

feat(sdk): add optional userAddress and privateKey to JsonRpcTxSubmit…

bae0f81

…ter props

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: evm multi chain signer #7

feat: evm multi chain signer #7

ljankovic-txfusion commented Nov 12, 2024

ltyu left a comment

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ljankovic-txfusion Nov 13, 2024

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ljankovic-txfusion Nov 13, 2024

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ltyu Nov 12, 2024

ljankovic-txfusion Nov 13, 2024

ljankovic-txfusion Nov 13, 2024

ljankovic-txfusion Nov 13, 2024

feat: evm multi chain signer #7

Are you sure you want to change the base?

feat: evm multi chain signer #7

Conversation

ljankovic-txfusion commented Nov 12, 2024

ltyu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment