feat: zksync deployment logic [ZK-002] #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/zksync-deployment-functions
typescript/sdk/src/deploy/proxy.ts
Outdated
| @@ -7,6 +8,8 @@ import { transferOwnershipTransactions } from '../contracts/contracts.js'; | |||
| import { AnnotatedEV5Transaction } from '../providers/ProviderType.js'; | |||
| import { DeployedOwnableConfig } from '../types.js'; | |||
|
|
|||
| type Provider = ethers.providers.Provider | ZKSyncProvider; | |||
There was a problem hiding this comment.
ethers Provider and ZKSync Provider are not compatible with each other
There was a problem hiding this comment.
Can we maybe pick a more descriptive name for the Union type?
There was a problem hiding this comment.
picked NetworkProvider
nambrot
approved these changes
Jan 22, 2025
typescript/sdk/src/deploy/proxy.ts
Outdated
| @@ -7,6 +8,8 @@ import { transferOwnershipTransactions } from '../contracts/contracts.js'; | |||
| import { AnnotatedEV5Transaction } from '../providers/ProviderType.js'; | |||
| import { DeployedOwnableConfig } from '../types.js'; | |||
|
|
|||
| type Provider = ethers.providers.Provider | ZKSyncProvider; | |||
There was a problem hiding this comment.
Can we maybe pick a more descriptive name for the Union type?
typescript/sdk/src/ism/types.ts
Outdated
| @@ -67,6 +67,16 @@ export const MUTABLE_ISM_TYPE = [ | |||
| IsmType.PAUSABLE, | |||
| ]; | |||
|
|
|||
| // ISM types that require static deployment | |||
| export const STATIC_ISM_TYPE = [ | |||
There was a problem hiding this comment.
Nit:
Suggested change
| export const STATIC_ISM_TYPE = [ | |
| export const STATIC_ISM_TYPES = [ |
There was a problem hiding this comment.
Resolved. Made a separate commit, since its used in multiple places
…in ISM type definitions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
…eat/zksync-deployment-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ZKSync-specific deployment logic to the SDK, introducing specialized utilities for contract deployment, artifact management, and technical stack compatibility checks for ZKSync.
Drive-by changes
Related issues
None
Backward compatibility
Yes
Testing
Build passing