Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #85 unreliable torch #111

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix: #85 unreliable torch #111

merged 2 commits into from
Jul 10, 2023

Conversation

nitricware
Copy link
Contributor

@nitricware nitricware commented Jul 2, 2023

Fixes an issue where the CaptureSession became unresponsive while the torch was on or where the CaptureSession wouldn't properly start at all when the torch was on by default.
Fixes #85

Fixes an issue where the CaptureSession became unresponsive while the torch was on or where the CaptureSession wouldn't properly start at all when the torch was on by default.
@nitricware nitricware mentioned this pull request Jul 2, 2023
@nitricware
Copy link
Contributor Author

You're right.
Curious why it worked on my device.
With this fix it should now work.

I'm new to contributing to packages and my workflow may be sub-optimal at best (I'm sure it is)
I copied the code into my project and tweaked it until it worked. then i copied the two files back to the repository, commited and pushed and filed a pull a request. do you have any resources on how to make this better/easier?

@demolisher2000
Copy link

@nathanfallet Is it possible to merge this fix and produce a new version? We would like to use this library, but this bug is blocking us from it

@nathanfallet
Copy link
Collaborator

@nathanfallet Is it possible to merge this fix and produce a new version? We would like to use this library, but this bug is blocking us from it

Sorry I didn't see the notification he fixed the thing, and forgot to check. I'm merging that!

@nathanfallet nathanfallet merged commit bf5d708 into twostraws:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreliable torch
3 participants