Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

found each QR code separately in manual mode #104

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

hossinasaadi
Copy link
Contributor

found each QR code separately in manual mode for 2 or more QR in one picture

@nathanfallet
Copy link
Collaborator

I think it would be better to call the method with an array, so that we keep the fact that codes where scanned at the same time, calling only once the handler (the handler might not be doing great if called multiple times)

@hossinasaadi
Copy link
Contributor Author

I think it would be better to call the method with an array, so that we keep the fact that codes where scanned at the same time, calling only once the handler (the handler might not be doing great if called multiple times)

In that case, the completion method should change to an array.
BTW, the changes I have made are just like the .continuous mode and I don't think it makes problems

@nathanfallet
Copy link
Collaborator

You're right.

@nathanfallet nathanfallet merged commit a147b22 into twostraws:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants