-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong reference cycle causing a memory leak #150
Comments
xmanu
added a commit
to xmanu/CodeScanner
that referenced
this issue
Aug 23, 2024
mooshee
added a commit
to share-eth/CodeScanner
that referenced
this issue
Sep 5, 2024
fix strong reference cycle as outlined in twostraws#150
I'm sorry if this is bad etiquette or too pushy: Is there any way this could be merged soonish? The change is really small and it would be nice if this could be released as a new version. I don't know who to tag here, maybe @nathanfallet or @twostraws ? Otherwise I have to link our project to my branch, which I would really like to prevent... |
Since this has been merged, shouldn't it be marked as closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent versions of CodeScanner contain a strong reference cycle and therefore prevent the view from being correctly released.
This was introduced somewhere after version 2.0.0.
This might also be the culprit for #121.
I have isolated the issue to the strong reference of
[self]
being captured while creating the handler. I will shortly create a PR to fix this issue.The text was updated successfully, but these errors were encountered: