-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding raite dataset documentation #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many questions need explication in Step 1. I've not reviewed beyond that.
This is not "you should have known the level of specificity that Matt wanted", but rather "this is how Matt is communicating the level he wants". I expected this iteration would happen.
@@ -0,0 +1,120 @@ | |||
# How to add a new dataset into armory | |||
I will use the RAIT dataset as an example. It is an object detection dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/RAIT/RAITE/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and throughout the document
# How to add a new dataset into armory | ||
I will use the RAIT dataset as an example. It is an object detection dataset. | ||
|
||
## Step 1 download dataset and locate all file in a folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all files in a
|
||
## Step 1 download dataset and locate all file in a folder | ||
|
||
Use the RAITE dataset as an example. The train/test json files are loaded in which contain the image name, label, bboxes, and etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the RAITE…
@@ -0,0 +1,120 @@ | |||
# How to add a new dataset into armory | |||
I will use the RAIT dataset as an example. It is an object detection dataset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should read
It is an object detection dataset drawn from TwoSix field exercises under the RAITE program. This dataset will not be available to you. The characteristics of this dataset are:
Chris we should strongly consider making this accessible at least upon request. We'll have to ask Etienne about distribution limitations that it might have
|
||
## Step 1 download dataset and locate all file in a folder | ||
|
||
Use the RAITE dataset as an example. The train/test json files are loaded in which contain the image name, label, bboxes, and etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"and etc." is redundant since "et cetera" means "and others"
Do be explicit here, what exactly do the json files contain? image name is likely obvious. The label could be ordinal, string enumeration. How many bboxes and what label applies to them? What is "and others"?
A sample, possibly abbreviated record example would really help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/What is the test / train split? How will the subsets be used by armory?
Markdown file describing process of putting RAITE dataset in correct format for armory library.