Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71 cull uninteresting examples #117

Merged
merged 12 commits into from
Jan 18, 2024
Merged

Conversation

treubig26
Copy link
Collaborator

Reduces OD examples to the following three:

  • License plates with YOLOS
  • License plates with YOLOv5
  • COCO with FasterRCNN

Cleans up notebooks:

  • Adds simple notebook demonstrating the license plates YOLOS example
  • Removes other obsolete notebooks
  • Adds pre-commit hook to strip notebook output
    • keep_output cell tag used to retain output on interesting cells

@treubig26 treubig26 requested a review from mwartell January 12, 2024 21:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably you thought this worth keeping? If so it deserves a better name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitbhub is showing "outputs changed" for this file where the diffs show no diffs(??). That's not a problem in itself, but oughtn't nbstripout have cleared them? I'll check by hand

@@ -589,6 +589,7 @@
}
],
"metadata": {
"keep_output": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwartell this tag at the notebook level is telling nbstripout to keep output for all cells in the notebook.

@treubig26 treubig26 merged commit 2949e2d into master Jan 18, 2024
24 checks passed
@treubig26 treubig26 deleted the 71-cull-uninteresting-examples branch January 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants