#380 bugf: accept react 18 peer dep #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this just bumps the peer deps and then it works npm i fails because of eslint packages. i removed them because id rather have a working production build than eslint tools.
TheEgghead27
added a commit
to stuysu/stuyactivities.org
that referenced
this pull request
Aug 22, 2022
Removes `@material-ui/lab` because all lab dependencies have been mainlined Removes `@material-ui/pickers`, but has not replaced it with the new MUI X version (`@mui/x-date-pickers`). Adds and bumps some new dependencies of the MUI v5 packages Bumps `notistack` to 2.0.10 (from 1.0.10), no breaking changes were noted in the package changelogs Removes `react-lazyload` due to being outdated and incompatible with React 18, but a fork is available at twobin/react-lazyload#387 which may serve as a stop-gap while a replacement is found.
TheEgghead27
added a commit
to stuysu/stuyactivities.org
that referenced
this pull request
Aug 23, 2022
Removes `@material-ui/lab` because all lab dependencies have been mainlined Removes `@material-ui/pickers`, but has not replaced it with the new MUI X version (`@mui/x-date-pickers`). Adds and bumps some new dependencies of the MUI v5 packages Bumps `notistack` to 2.0.10 (from 1.0.10), no breaking changes were noted in the package changelogs Removes `react-lazyload` due to being outdated and incompatible with React 18, but a fork is available at twobin/react-lazyload#387 which may serve as a stop-gap while a replacement is found.
TheEgghead27
added a commit
to stuysu/stuyactivities.org
that referenced
this pull request
Sep 24, 2022
Removes `@material-ui/lab` because all lab dependencies have been mainlined Removes `@material-ui/pickers`, but has not replaced it with the new MUI X version (`@mui/x-date-pickers`). Adds and bumps some new dependencies of the MUI v5 packages Bumps `notistack` to 2.0.10 (from 1.0.10), no breaking changes were noted in the package changelogs Removes `react-lazyload` due to being outdated and incompatible with React 18, but a fork is available at twobin/react-lazyload#387 which may serve as a stop-gap while a replacement is found.
TheEgghead27
added a commit
to stuysu/stuyactivities.org
that referenced
this pull request
Oct 1, 2022
Removes `@material-ui/lab` because all lab dependencies have been mainlined Removes `@material-ui/pickers`, but has not replaced it with the new MUI X version (`@mui/x-date-pickers`). Adds and bumps some new dependencies of the MUI v5 packages Bumps `notistack` to 2.0.10 (from 1.0.10), no breaking changes were noted in the package changelogs Removes `react-lazyload` due to being outdated and incompatible with React 18, but a fork is available at twobin/react-lazyload#387 which may serve as a stop-gap while a replacement is found.
TheEgghead27
added a commit
to stuysu/stuyactivities.org
that referenced
this pull request
Oct 1, 2022
Removes `@material-ui/lab` because all lab dependencies have been mainlined Removes `@material-ui/pickers`, but has not replaced it with the new MUI X version (`@mui/x-date-pickers`). Adds and bumps some new dependencies of the MUI v5 packages Bumps `notistack` to 2.0.10 (from 1.0.10), no breaking changes were noted in the package changelogs Removes `react-lazyload` due to being outdated and incompatible with React 18, but a fork is available at twobin/react-lazyload#387 which may serve as a stop-gap while a replacement is found.
|
Hello @ameerthehacker and @twobin can you please accept this change so its compatible with react 18? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this just bumps the peer deps and then it works
npm i fails because of eslint packages. i removed them because id rather have a working production build than eslint tools.
#380
in the mean time i published a fork with this change on npm: https://www.npmjs.com/package/parm-react-lazyload
this fork most likely will not be maintained. just a stop gap to keep my builds running until i come up with a long term solution