Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework #2

Merged
merged 5 commits into from
May 9, 2020
Merged

Rework #2

merged 5 commits into from
May 9, 2020

Conversation

Chingaipe
Copy link
Collaborator

This is what I've come up with. We can tweak it further with any other suggestion you have. #1

Screenshot

Screenshot_20200401-194148__01

@twmbx twmbx linked an issue Apr 20, 2020 that may be closed by this pull request
@twmbx
Copy link
Owner

twmbx commented Apr 21, 2020

@Chingaipe so I had a look and think you made nice changes; thanks!

I went over things and removed commented out code.
Also refactored the code with the new take-home salary widget you created.
The shadow around that widget was being clipped on the left and right sides so I increased the horizontal margin so that it is visible in its entirety:

Screenshot from 2020-04-21 12-50-26

I'm looking into the icons next as I think the "exempt" and "taxable icons could be more specific.
I'm thinking maybe a safe/vault for the "exempt" from tax, and maybe a bank note being cut by scissors for the "taxable" icon (if it will be visible/fit at such a small size).

Screenshot from 2020-04-21 12-52-10

Where did you source the icons that you used? are they free for use? CC0? or do they need some form of credit? It would be prudent to make sure that they don't infringe on anyone's copyright.

@Chingaipe
Copy link
Collaborator Author

I agree those icons could be specialized.
All the icons are from flaticon.com and yes, we'll need to credit them for using the icons.

<div>Icons made by <a href="https://www.flaticon.com/authors/freepik" title="Freepik">Freepik</a> from <a href="https://www.flaticon.com/" title="Flaticon">www.flaticon.com</a></div>

Added new icons with better relevance for "Exempt" & Taxable income. Added an icon for "Take home amount".

Added attribution for icons used.
@twmbx twmbx merged commit 729badb into master May 9, 2020
@twmbx twmbx deleted the rework branch May 9, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Rework
2 participants