-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI from Travis CI to GitHub Actions #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we need to take the block as a proc, not as an argument. refs: rr/rr@d6da209#diff-a20b4cc1aac26c32a40206ad0776d4ff528201e97b737b7b3f0be1eb0e12e93dL44-L49
The following test cases fail when running CI in Ruby 3.0. ``` 1) Failure: Twurl::CLI::OptionParsingTest#test_setting_host_updates_to_requested_value [/home/runner/work/twurl/twurl/test/cli_test.rb:214]: Expected: "localhost:3000" Actual: "api.twitter.com" 2) Failure: Twurl::CLI::OptionParsingTest#test_setting_proxy_updates_to_requested_value [/home/runner/work/twurl/twurl/test/cli_test.rb:237]: Expected: "localhost:80" Actual: nil 3) Failure: Twurl::CLI::OptionParsingTest#test_passing_no_ssl_option_disables_ssl [/home/runner/work/twurl/twurl/test/cli_test.rb:196]: Expected false to be truthy. 4) Failure: Twurl::CLI::OptionParsingTest#test_specifying_a_request_method_extracts_and_normalizes_request_method [/home/runner/work/twurl/twurl/test/cli_test.rb:54]: Expected: "put" Actual: "get" 5) Failure: Twurl::CLI::OptionParsingTest#test_protocol_is_stripped_from_host [/home/runner/work/twurl/twurl/test/cli_test.rb:221]: Expected: "localhost:3000" Actual: "api.twitter.com" 6) Failure: Twurl::CLI::OptionParsingTest#test_passing_data_and_an_explicit_request_method_uses_the_specified_method [/home/runner/work/twurl/twurl/test/cli_test.rb:148]: Expected: "delete" Actual: "post" 7) Failure: Twurl::Options::Test#test_ssl_is_enabled_if_the_protocol_is_https [/home/runner/work/twurl/twurl/test/cli_options_test.rb:18]: Expected false to be truthy. 8) Failure: Twurl::Options::Test#test_base_url_is_built_from_protocol_and_host [/home/runner/work/twurl/twurl/test/cli_options_test.rb:13]: Expected: "http://api.twitter.com" Actual: "https://api.twitter.com" ``` According to twitter#159 (comment), the cause appears to be a bug in OpenStruct. The bug was fixed in ruby/ostruct#23, and released as v0.3.3.
- OpenStruct v0.3.3+ requires Ruby 2.5+. - It's already reached EOL on 2020-03-31.
CLA Assistant Lite bot All Contributors have signed the CLA. If the commit check is not passing, a maintainer must go the Checks tab of this PR and rerun the GitHub Action. |
recheck |
I have read the CLA Document and I hereby sign the CLA |
smaeda-ks
approved these changes
Apr 15, 2022
This looks good to me, thanks @mishina2228 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #170.
Problem
Since June 15th, 2021, the building on travis-ci.org is ceased.
Solution
This PR migrates CI from Travis CI to GitHub Actions.
Here are the details:
Add Ruby 3.0 and 3.1 to the CI matrix
rbx-2
is not included becauseruby/setup-ruby
does not support it.Remove Coveralls
Address changes in RR v3.0.0
refs: rr/rr@d6da209#diff-a20b4cc1aac26c32a40206ad0776d4ff528201e97b737b7b3f0be1eb0e12e93dL44-L49
Require OpenStruct v0.3.3+
Details
@smaeda-ks Thanks for letting me know!
Drop support for Ruby 2.4
(Ruby 2.5 and 2.6 has reached EOL also, though)
Replace the CI status badge on README.md
The CI status can be checked here.