Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala 2.12 and 2.13 #913

Merged
merged 6 commits into from
Feb 6, 2021
Merged

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Jan 16, 2021

No description provided.

@regadas
Copy link
Collaborator Author

regadas commented Jan 16, 2021

build fails due to scoverage scoverage/sbt-scoverage#319

@codecov-io
Copy link

codecov-io commented Jan 24, 2021

Codecov Report

Merging #913 (c4fb65b) into develop (47c37a9) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #913      +/-   ##
===========================================
+ Coverage    89.60%   89.62%   +0.02%     
===========================================
  Files          119      119              
  Lines         9869     9869              
  Branches       494      494              
===========================================
+ Hits          8843     8845       +2     
+ Misses        1026     1024       -2     
Impacted Files Coverage Δ
.../main/scala/com/twitter/algebird/Approximate.scala 88.70% <0.00%> (-1.62%) ⬇️
...re/src/main/scala/com/twitter/algebird/QTree.scala 78.57% <0.00%> (-1.20%) ⬇️
.../main/scala/com/twitter/algebird/BloomFilter.scala 94.24% <0.00%> (-0.45%) ⬇️
.../main/scala/com/twitter/algebird/HyperLogLog.scala 90.04% <0.00%> (+0.43%) ⬆️
...src/main/scala/com/twitter/algebird/Interval.scala 80.86% <0.00%> (+1.73%) ⬆️
.../main/scala/com/twitter/algebird/Applicative.scala 55.17% <0.00%> (+3.44%) ⬆️
.../main/scala/com/twitter/algebird/Successible.scala 91.66% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c37a9...c4fb65b. Read the comment docs.

@johnynek
Copy link
Collaborator

Huh, the micro site is failing somehow. I haven't checked the logs.

@regadas
Copy link
Collaborator Author

regadas commented Jan 31, 2021

Right, the error is related to tut which is removed in #920

@johnynek
Copy link
Collaborator

johnynek commented Feb 2, 2021

so, if we merge #920 this should be good to go?

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

@johnynek johnynek merged commit ba3872d into twitter:develop Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants