Use vendored version of utoipa-swagger-ui #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the `vendored` feature, `utoipa-swagger-ui` build script retrieves the swagger-ui files at build time. This requires network access when building rtz, even when Rust dependencies have been vendored.
|
This prevents, for example, NixOS packages from being built without hardcoding the swagger-ui files, as NixOS builders don't have access to the network by default to ensure reproducible builds. If you merge this, could you please release rtz 0.7.1 so that we can update the NixOS build? |
13 tasks
|
Ping @twitchax? |
|
Hey, sorry. I missed this somehow. Taking a look now. |
twitchax
approved these changes
Sep 19, 2024
|
No problem. Do you plan to cut a patch release soon so that we can update the NixOS package? |
|
Plan is "in a few moments!" :) |
|
The crate is published. GH to be updated soon. |
|
Thanks! The nixpkgs update is in NixOS/nixpkgs#343066. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
vendoredfeature,utoipa-swagger-uibuild script retrieves the swagger-ui files at build time. This requires network access when building rtz, even when Rust dependencies have been vendored.