test on python 3.12 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so it turns out the 3.12 tests don't actually cover the build process |
graingert
force-pushed
the
test-on-3.12
branch
from
8358fcc to
31b285c
Compare
graingert
force-pushed
the
test-on-3.12
branch
from
e584a9d to
7ed308d
Compare
adiroiban
approved these changes
Oct 26, 2023
| @@ -54,10 +54,13 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| allow-prereleases: true | |||
|
|
|||
| - name: Test build | |||
| run: pipx run --python=python build . | |||
There was a problem hiding this comment.
I see that build is called before the deps are installed.
Is that ok ?
adiroiban
reviewed
Oct 26, 2023
| @@ -40,4 +44,5 @@ def read(*parts): | |||
| maintainer='Twisted Matrix Labs Developers', | |||
| version=versioneer.get_version(), | |||
| cmdclass=versioneer.get_cmdclass(), | |||
| python_requires=">= 3.8", | |||
There was a problem hiding this comment.
I think that we also need to remove the universal build
The resulting wheel is
constantly-0+untagged.1.g6bbe661-py2.py3-none-any.whl
This was referenced Oct 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.