-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PublicSuffix and Addressable #117
Conversation
Unfortunately it doesn't look like this fixes any of our issues, but since it made the profiling run a bit faster (and the fact that the tests didn't break) I made a PR of this anyway. (Profiling total run: 1.6663s -> 1.4801s). Some related links: * weppos/publicsuffix-ruby#130 * weppos/publicsuffix-ruby#133 * sporkmonger/addressable#267
We could take the opportunity and think about: #104 (comment) My experience that going from loose requirements to strict ones made it a bit cumbersome for Bundler to figure out how to update. I would usually end up with |
Just a note: We need at least Addressable |
We could allow for something like: public_suffix >= 2, < 4 and something similar for addressable and let bundler figure out the rest. I am not really sure about how we properly test all combinations though. |
Looks like Travis already thought of that: https://docs.travis-ci.com/user/languages/ruby/#Testing-against-multiple-versions-of-dependencies, though we have to create the gemfiles manually. |
Pleading for a new release with this PR merged, because the |
Let's get this merged and released and then loosen up the dependencies and test with multiple gemfiles. |
Related to #117 and #104 (comment).
Awesome, @dentarg , thanks a lot!! |
Unfortunately it doesn't look like this fixes any of our issues, but since it made the profiling run a bit faster (and the fact that the tests didn't break) I made a PR of this anyway.
Profiling "total run time" went from
1.6663s
to1.4801s
.Some related links: