VBLOCKS-2485: Changes needed due to refactor of react native sdk #129
Conversation
afalls-twilio
changed the title
| } | ||
| } | ||
|
|
||
| private final VoiceActivityProxy activityProxy = new VoiceActivityProxy( |
There was a problem hiding this comment.
Clarifying Question: Will users who just use the SDK also need to make these changes in their React Native Apps?
I.E: users not using the reference app, but using the sdk
There was a problem hiding this comment.
yes, but we are still in beta, and it will make customers lives easier down the line... because we abstract much of it.
There was a problem hiding this comment.
It seems like these changes will be included in beta.4, could we have a guide to updating to beta.4 for users who are on beta.3 and below?
There was a problem hiding this comment.
@mhuynh5757 https://issues.corp.twilio.com/browse/VBLOCKS-2556 has been created
| if (Manifest.permission.RECORD_AUDIO.equals(permission)) { | ||
| Toast.makeText( | ||
| MainActivity.this, | ||
| "Microphone permissions needed. Please allow in your application settings.", |
There was a problem hiding this comment.
Android doesn't automatically give these prompts?
There was a problem hiding this comment.
nope, it only places a system pop-up when you request permissions.... but they can always disable it later from the system menus.
| import com.microsoft.appcenter.AppCenter; | ||
| import com.microsoft.appcenter.distribute.Distribute; | ||
| import com.twiliovoicereactnativereferenceapp.newarchitecture.MainApplicationReactNativeHost; | ||
|
|
| AppCenter.start(this, BuildConfig.APPCENTER_APP_KEY, Distribute.class); | ||
| @Override | ||
| public void onTerminate() { | ||
| // Note: this method is not called when running on device, devies just kill the process. |
app/android/build.gradle
Outdated
| @@ -25,7 +19,7 @@ buildscript { | |||
| classpath("com.facebook.react:react-native-gradle-plugin") | |||
| classpath("de.undercouch:gradle-download-task:5.0.1") | |||
| classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion") | |||
| classpath("com.google.gms:google-services:4.3.15") | |||
| classpath("com.google.gms:google-services:4.3.0") | |||
There was a problem hiding this comment.
We want to downgrade from 4.3.15 to 4.3.0?
There was a problem hiding this comment.
hmm, let me test.... I believe I did that to limit issues with overlapping dependencies...
afalls-twilio
changed the title
Submission Checklist
README.mdreflects new featuresCHANGELOG.mdreflects any feature, bug fixes, or known issues made in the source codeFiles changedtab was made prior to submitting the pull request ensuring the style guide was followedDescription
Updated to reflect changes in react native SDK
Breakdown
Validation
Additional Notes
None
Contributing to Twilio