Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove brackets #648

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: remove brackets #648

merged 1 commit into from
Feb 8, 2023

Conversation

claudiachua
Copy link
Contributor

Address feedback from #640

@rakatyal
Copy link
Contributor

rakatyal commented Feb 8, 2023

Could you link the PR with the generator changes?

@claudiachua
Copy link
Contributor Author

claudiachua commented Feb 8, 2023 •
edited
Loading

@rakatyal The shortcuts ( __init__.py) are no longer generated files when I had them split out in #640. So I had to manually removed them

@claudiachua claudiachua merged commit 02ccd56 into 8.0.0-rc Feb 8, 2023
@claudiachua claudiachua deleted the remove-brackets branch February 8, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakatyal rakatyal rakatyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudiachua @rakatyal