Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new max_retries param to TwilioHttpClient #507

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

msaelices
Copy link
Contributor

@msaelices msaelices commented Feb 17, 2020

Fixes #506

Fixes the #506 issue by retrying the failed connection.

I've seen something similar implemented in the Java version: https://github.com/twilio/twilio-java/blob/master/src/main/java/com/twilio/http/HttpClient.java

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

twilio/http/http_client.py Outdated Show resolved Hide resolved
@childish-sambino childish-sambino changed the title Fix random SSLErrors by retrying the requests, with a new max_retries param feat: add new max_retries param to TwilioHttpClient Feb 27, 2020
@childish-sambino childish-sambino merged commit cae59ba into twilio:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random SSLErrors when calling the REST API
2 participants