Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: temporarily remove log test #620

Merged
merged 2 commits into from
Feb 2, 2021
Merged

fix: temporarily remove log test #620

merged 2 commits into from
Feb 2, 2021

Conversation

thinkingserious
Copy link
Contributor

This test needs to be refactored to test the slf4j logging facade with at least one implementation, likely log4j.

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license

JenniferMah
JenniferMah reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the testing dependency on log4j in the pom.xml file? Then add that dependency back if needed when we re-add tests?

@thinkingserious
Copy link
Contributor Author

Updated, thank you!

JenniferMah
JenniferMah approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkingserious thinkingserious merged commit 3760331 into main Feb 2, 2021
@thinkingserious thinkingserious deleted the removelogtest branch February 2, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniferMah JenniferMah JenniferMah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkingserious @JenniferMah