-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: paging breaks with + sign on phone number #571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was how I reproduced #569: git clone https://github.com/twilio/twilio-java.git
cd twilio-java
touch ReproduceTwilioBug.java
import com.google.common.collect.Iterators;
import com.twilio.Twilio;
import com.twilio.base.ResourceSet;
import com.twilio.rest.api.v2010.account.Call;
public class ReproduceTwilioBug {
static {
String accountSid = System.getenv("TWILIO_ACCOUNT_SID");
String authToken = System.getenv("TWILIO_AUTH_TOKEN");
Twilio.init(accountSid, authToken);
}
public static void main(final String args[]) {
String toPhoneNumber = System.getenv("TWILIO_TO_PHONE_NUMBER");
final String to = toPhoneNumber;
countCalls(to);
countCalls(to.replace("+", ""));
}
static void countCalls(final String to) {
ResourceSet<Call> calls = Call.reader().setTo(to).pageSize(5).limit(20).read();
System.out.println("For " + to + " " + Iterators.size(calls.iterator()) + " calls.");
}
} mvn install -DskipTests
javac -classpath ./target/twilio-7.55.0-jar-with-dependencies.jar:. ReproduceTwilioBug.java && java -classpath ./target/twilio-7.55.0-jar-with-dependencies.jar:. ReproduceTwilioBug Result: For +1951XXXXXXX 5 calls.
For 1951XXXXXXX 6 calls. After this fix, Result: For +1951XXXXXXX 6 calls.
For 1951XXXXXXX 6 calls. |
childish-sambino
suggested changes
Aug 27, 2020
Is there any overlap with #570? |
#570 seems related to not handling non-JSON return values when paging fails. To be sure, I'd like to reproduce that one as well. |
eshanholtz
reviewed
Sep 16, 2020
childish-sambino
approved these changes
Sep 17, 2020
eshanholtz
reviewed
Sep 17, 2020
eshanholtz
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Checklist