Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow conference participant to be any endpoint #559

Merged
merged 18 commits into from
Apr 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ public static ParticipantUpdater updater(final String pathConferenceSid,
*/
public static ParticipantCreator creator(final String pathAccountSid,
final String pathConferenceSid,
final com.twilio.type.PhoneNumber from,
final com.twilio.type.PhoneNumber to) {
final com.twilio.type.Endpoint from,
eshanholtz marked this conversation as resolved.
Show resolved Hide resolved
final com.twilio.type.Endpoint to) {
return new ParticipantCreator(pathAccountSid, pathConferenceSid, from, to);
}

Expand All @@ -157,8 +157,8 @@ public static ParticipantCreator creator(final String pathAccountSid,
* @return ParticipantCreator capable of executing the create
*/
public static ParticipantCreator creator(final String pathConferenceSid,
final com.twilio.type.PhoneNumber from,
final com.twilio.type.PhoneNumber to) {
final com.twilio.type.Endpoint from,
final com.twilio.type.Endpoint to) {
return new ParticipantCreator(pathConferenceSid, from, to);
}

Expand Down Expand Up @@ -489,4 +489,4 @@ public int hashCode() {
status,
uri);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
public class ParticipantCreator extends Creator<Participant> {
private String pathAccountSid;
private final String pathConferenceSid;
private final com.twilio.type.PhoneNumber from;
private final com.twilio.type.PhoneNumber to;
private final com.twilio.type.Endpoint from;
private final com.twilio.type.Endpoint to;
private URI statusCallback;
private HttpMethod statusCallbackMethod;
private List<String> statusCallbackEvent;
Expand Down Expand Up @@ -73,8 +73,8 @@ public class ParticipantCreator extends Creator<Participant> {
* this call.
*/
public ParticipantCreator(final String pathConferenceSid,
final com.twilio.type.PhoneNumber from,
final com.twilio.type.PhoneNumber to) {
final com.twilio.type.Endpoint from,
final com.twilio.type.Endpoint to) {
this.pathConferenceSid = pathConferenceSid;
this.from = from;
this.to = to;
Expand All @@ -92,8 +92,8 @@ public ParticipantCreator(final String pathConferenceSid,
*/
public ParticipantCreator(final String pathAccountSid,
final String pathConferenceSid,
final com.twilio.type.PhoneNumber from,
final com.twilio.type.PhoneNumber to) {
final com.twilio.type.Endpoint from,
final com.twilio.type.Endpoint to) {
this.pathAccountSid = pathAccountSid;
this.pathConferenceSid = pathConferenceSid;
this.from = from;
Expand Down Expand Up @@ -921,4 +921,4 @@ private void addPostParams(final Request request) {
request.addPostParam("RecordingTrack", recordingTrack);
}
}
}
}