Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add URI encoding for phone numbers #494

Merged
merged 1 commit into from
Nov 15, 2019
Merged

fix: Add URI encoding for phone numbers #494

merged 1 commit into from
Nov 15, 2019

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Nov 15, 2019 •
edited
Loading

Fixes #399

childish-sambino
childish-sambino approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested that the code samples actually work now.

@eshanholtz eshanholtz merged commit b33b438 into master Nov 15, 2019
@eshanholtz eshanholtz deleted the phone-number-encoding branch November 15, 2019 19:29
@eshanholtz
Copy link
Contributor Author

Fixes #399

FalguniV pushed a commit to FalguniV/twilio-java that referenced this pull request Oct 13, 2020
@eshanholtz @FalguniV
add URI encoding for phone numbers (twilio#494)
df77fcd
FalguniV pushed a commit to FalguniV/twilio-java that referenced this pull request Oct 13, 2020
@eshanholtz @FalguniV
add URI encoding for phone numbers (twilio#494)
f23b8d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phone Lookup failing when phone number have space in it
2 participants
@eshanholtz @childish-sambino