fix: publish win32 and darwin artifacts to release assets #474
Conversation
| core.setFailed(`Exiting, required param: ASSET_NAME is missing`); | ||
| return; | ||
| } | ||
| if(!('FILE' in process.env) && !('DIRNAME' in process.env)){ |
There was a problem hiding this comment.
Should this be an OR condition / AND ? The error message says OR.
There was a problem hiding this comment.
Need to modify the error message.
| }) | ||
| release_id: oldReleaseId | ||
| }); | ||
| const duplicate_asset = assets.data.find(a => a.name === assetName) |
There was a problem hiding this comment.
Any sample runs to validate duplicate_asset logic block?
| @@ -25,8 +25,8 @@ jobs: | |||
| matrix: | |||
| include: | |||
| - os: macos-latest | |||
| asset_name: twilio-v${{ github.event.inputs.tag-name }} | |||
| command_name: npx oclif-dev pack --xz -t darwin-arm64,darwin-x64,linux-arm,linux-x64,win32-x64,win32-x86 | |||
There was a problem hiding this comment.
Do we need to remove the build targets too? IIRCtwilio update refers the vanilla builds from s3. How does it work after this change?
There was a problem hiding this comment.
Yes, I missed that. Thanks!!
| id: sha256 | ||
| if: ${{matrix.publish == 'homebrew'}} | ||
| run: | | ||
| make clean | ||
| make install | ||
| npx oclif-dev publish |
There was a problem hiding this comment.
Won't we still need to publish the darwin tarballs?
There was a problem hiding this comment.
Darwin tarballs will only be needed by twilio update cmd, which can fetch them successfully from the release assets. I don't think if there's a need to publish them to s3 bucket.
| @@ -148,7 +148,21 @@ | |||
| "update": { | |||
| "s3": { | |||
| "xz": true, | |||
| "bucket": "twilio-cli-prod" | |||
There was a problem hiding this comment.
How are we publishing apt artefacts ?
There was a problem hiding this comment.
That needs to be handled differently as part of buildkite job.
|
Kudos, SonarCloud Quality Gate passed!
|
Fixes DII-694
The darwin and win artifacts which were previously hosted on aws-s3, will now be published to github release assets. Homebrew and scoop repositories will have relevant changes to pick up the release assets.
Refer the 5.1.10 and 5.1.10-draft.2 releases to verify the changes. Changes made in scoop and homebrew repos to refer the release assets instead of aws-s3 bucket.
scoop-5.1.10 and scoop-5.1.10-draft.2
homebrew-5.1.10 and homebrew-5.1.10-draft.2
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.