Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date inequality support #41

Merged
merged 29 commits into from
Aug 8, 2019
Merged

Add date inequality support #41

merged 29 commits into from
Aug 8, 2019

Conversation

JenniferMah
Copy link
Contributor

Add in date> and date< parameters for messages.
When sending the request look for the CLI kebob case parameter name (date-sent-before) but return the correct API parameter name (DateSent<).
Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dprothero
Copy link
Contributor

  1. We shouldn't update src/services/twilio-api/twilio_api.json here as this is a generated file. I would revert changes to that file. Any changes we need to make will need to be added to the program that generates this file (an internal Twilio tool, will get you the link).

  2. "DateSent" isn't the only date inequality parameter name out there. (For example, /2010-04-01/Accounts/{AccountSid}/Calls/{CallSid}/Notifications.json has a parameter called MessageDate

So, you were right! I think we do need to update the OpenAPI spec to add the < and > parameters to the API spec and then you can code the CLI to adapt to those.

Copy link
Contributor

@dprothero dprothero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

… searching to CLI names when making request.
@childish-sambino childish-sambino merged commit 371b930 into master Aug 8, 2019
@childish-sambino childish-sambino deleted the DateInequality branch August 8, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants