Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next page of results requests #40

Closed
wants to merge 1 commit into from

Conversation

kuryaki
Copy link

@kuryaki kuryaki commented Jul 16, 2019

Reported this issue: twilio/twilio-cli#74
It breaks when listing items that have more than one page, nextPageUrl contains the full path, so adding the host to it will create a bad URL

https://messaging.twilio.comhttps://messaging.twilio.com/v1/Services?PageSize=50&Page=1&PageToken=XXXX

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@childish-sambino
Copy link
Contributor

I don’t think this works if the next page url is relative. Looks like logic is needed to check if the next page is relative or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants