Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:Added changes to use scripts instead of community Github actions #155

Merged
merged 3 commits into from
Sep 28, 2021
Merged

chore:Added changes to use scripts instead of community Github actions #155

merged 3 commits into from
Sep 28, 2021

Conversation

ravali-rimmalapudi
Copy link
Contributor

Fixes

Conversion of community Github actions into scripts.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@shrutiburman shrutiburman mentioned this pull request Sep 28, 2021
Merged
8 tasks
@ravali-rimmalapudi ravali-rimmalapudi changed the title Added changes to use scripts instead of community Github actions chore:Added changes to use scripts instead of community Github actions Sep 28, 2021
shrutiburman
shrutiburman reviewed Sep 28, 2021
View reviewed changes
.github/workflows/release.yml Outdated
REPO_ACCESS_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
WORKFLOW_NAME: 'release.yml'
BRANCH_NAME: ${{github.event.inputs.cli-branch}}
REPO_NAME: LakshmiRavali/twilio-cli
Copy link
Contributor

@shrutiburman shrutiburman Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REPO_NAME To be updated later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing. Updated.

shrutiburman
shrutiburman previously approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the REPO_NAME comment, rest looks good to go. :)

shrutiburman
shrutiburman approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨

@ravali-rimmalapudi ravali-rimmalapudi merged commit 27bd508 into main Sep 28, 2021
@ravali-rimmalapudi ravali-rimmalapudi deleted the community_actions branch September 28, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman approved these changes

@Sindhura3 Sindhura3 Awaiting requested review from Sindhura3

@kridai kridai Awaiting requested review from kridai

@onuzbee onuzbee Awaiting requested review from onuzbee

@sr010 sr010 Awaiting requested review from sr010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravali-rimmalapudi @shrutiburman