Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twilio dependency in serverless-runtime-types #483

Closed
Humberd opened this issue Jul 3, 2023 · 2 comments
Closed

Update twilio dependency in serverless-runtime-types #483

Humberd opened this issue Jul 3, 2023 · 2 comments

Comments

@Humberd
Copy link

Humberd commented Jul 3, 2023

Currently serverless-runtime-types project uses a twilio dependency version 3.

However, the newest one is version 4.
If you install both newest versions in your project then you will get conflicts:

Type 'import("D:\\Repositories\\flexfunctions\\node_modules\\@twilio-labs\\serverless-runtime-types\\node_modules\\twilio\\lib\\rest\\api\\v2010\\account\\incomingPhoneNumber").IncomingPhoneNumberInstance' 
is not assignable to type 'import("D:\\Repositories\\flexfunctions\\node_modules\\twilio\\lib\\rest\\api\\v2010\\account\\incomingPhoneNumber").IncomingPhoneNumberInstance
@welcome
Copy link

welcome bot commented Jul 3, 2023

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog

@colossal-toby
Copy link
Contributor

colossal-toby commented Nov 29, 2023

Maintainers, please update the typings or provide some kind of warning about this issue.

Maybe add twilio: 3.60.0 as a peer dependency so we can at least know that it is the required version and not 4.x

makserik added a commit to makserik/serverless-toolkit that referenced this issue Jan 24, 2024
makserik added a commit to makserik/serverless-toolkit that referenced this issue Mar 18, 2024
…ndler, twilio-run): Twilio SDK

Twilio SDK bump from 3.x to 4.23 with fixes to types, tests

BREAKING CHANGE: Underlying Twilio SDK was bumped by a major version, Twilio SDK 3.x to 4.23. This
might require changes in how importing this package will work.

fix twilio-labs#473 twilio-labs#483 twilio-labs#455
makserik added a commit that referenced this issue Mar 20, 2024
* FRIDGE-814 upgrade to twilio 4.23.0, fix tests

* improvement(@twilio-labs/serverless-runtime-types, @twilio/runtime-handler, twilio-run): Twilio SDK

Twilio SDK bump from 3.x to 4.23 with fixes to types, tests

BREAKING CHANGE: Underlying Twilio SDK was bumped by a major version, Twilio SDK 3.x to 4.23. This
might require changes in how importing this package will work.

fix #473 #483 #455

* FRIDGE-814 revert logger.ts

* FRIDGE-814 add changeset

* improvement(plugin-serverless plugin-assets runtime-handler serverless-api serverless-twilio-runtime

change node.js to 18 minimum in required and in docs where necessary

BREAKING CHANGE: minimum Node.js now 18

* FRIDGE-814 remove node 16 github actions, make it use npm@10

* FRIDGE-814 replace deprecated npm-run-all with a maintained fork

* FRIDGE-814 remove npm-run-all deps and convert commands to regular as the package seems broken on windows

* add typescript install explicitly

* Revert "FRIDGE-814 remove node 16 github actions, make it use npm@10"

This reverts commit 2ca5371.

* remove node 16

* update snapshots

* fix snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants