Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and improve construction #44

Merged
merged 19 commits into from
Jun 22, 2024
Merged

Simplify and improve construction #44

merged 19 commits into from
Jun 22, 2024

Conversation

anders-wind
Copy link
Collaborator

@anders-wind anders-wind commented Jun 18, 2024 •
edited
Loading

Why

Currently move and forward constructors are missing opportunities.

What was changed

  • Remove most of the constructors and just keep a forwarding constructor.
  • Remove the can_forward_construct skill, since it is now always enabled.
  • Some static functions in benchmarks were moved into an anonymous namespace
  • Fixed a number of missing headers
  • Moved can_stream and can_hash into their own files
  • can_stream is now both for input and output streams. Use can_ostream and can_istream to only get one of their behaviors.

@anders-wind anders-wind force-pushed the feature/fix_constructors branch from a3ca765 to 396952e Compare June 18, 2024 09:16
@anders-wind anders-wind changed the title Add lvalue constructor for moveable types Simplify and improve construction Jun 18, 2024
@anders-wind anders-wind force-pushed the feature/fix_constructors branch from 1239821 to 49f34f1 Compare June 18, 2024 09:48
@anders-wind anders-wind force-pushed the feature/fix_constructors branch from 49f34f1 to 5bb09db Compare June 18, 2024 09:49
@anders-wind anders-wind force-pushed the feature/fix_constructors branch from e0c382f to 3accfa1 Compare June 18, 2024 10:40
@anders-wind anders-wind force-pushed the feature/fix_constructors branch 5 times, most recently from 813babb to cb842c3 Compare June 18, 2024 10:57
@anders-wind anders-wind force-pushed the feature/fix_constructors branch from cb842c3 to 0713a09 Compare June 18, 2024 10:59
@anders-wind anders-wind force-pushed the feature/fix_constructors branch from 51fd275 to e0c40ca Compare June 22, 2024 14:30
@anders-wind anders-wind force-pushed the feature/fix_constructors branch from e0c40ca to 330a906 Compare June 22, 2024 14:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 22, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
3 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anders-wind anders-wind merged commit d9f6fec into main Jun 22, 2024
17 checks passed
@anders-wind anders-wind deleted the feature/fix_constructors branch June 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaellindemann mikaellindemann mikaellindemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anders-wind @mikaellindemann