Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mathematica settings to use to right options and use -file by default #168

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

davnn
Copy link
Contributor

@davnn davnn commented Nov 7, 2022

There was a copy-paste error and the CSharp settings were used for Mathematica.
Running wolframscript without -file just leads to an interactive session, but doesn't run the code.

@davnn davnn changed the title Fix mathematica settings, to use to right options and -file by default Fix mathematica settings to use to right options and -file by default Nov 7, 2022
@davnn davnn changed the title Fix mathematica settings to use to right options and -file by default Fix mathematica settings to use to right options and use -file by default Nov 7, 2022
@chlohal chlohal changed the base branch from master to develop November 7, 2022 20:02
@chlohal
Copy link
Collaborator

chlohal commented Nov 7, 2022

Hi! Thank you for the contribution!

The first issue was already fixed by #152 :) . The second one is definitely still an issue, though; thank you for your fix!

I noticed that you were merging into master. I've changed it to develop: we usually merge together the next version on develop, while master is reserved for completed versions.

Thanks again!!! Bug-fixing PRs are always an enormous help! :D

Copy link
Collaborator

@chlohal chlohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry! disregard what I was saying about #152; we had a different copy/paste issue w/ Mathematica settings. Thank you for catching this one too!!!!

@twibiral
Copy link
Owner

Thank you very much @davnn !

@twibiral twibiral merged commit cafbd36 into twibiral:develop Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants