Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_cpu_value for bazel 8.0.0rc4 #613

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

kczulko
Copy link
Contributor

@kczulko kczulko commented Nov 27, 2024

Attempt to fix #612

@kczulko kczulko requested a review from a team as a code owner November 27, 2024 12:37
@avdv
Copy link
Member

avdv commented Nov 27, 2024

Hi @kczulko, I don't know if you've seen this, but the get_cpu_value function in rules_cc is private, and we thought vendoring a copy of it would be a better solution.

@kczulko
Copy link
Contributor Author

kczulko commented Nov 27, 2024

Hi Claudio,

I thought I could reference this function. However, legacy workspace dependency hell is a bit more complex to solve in comparison to "just changing" the place from which we take get_cpu_value function. I'll follow your advice. Thx!

Copy link
Collaborator

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@malt3 malt3 added the merge-queue merge on green CI label Nov 28, 2024
@mergify mergify bot merged commit 680f407 into tweag:master Nov 28, 2024
13 checks passed
@kczulko
Copy link
Contributor Author

kczulko commented Nov 28, 2024

@malt3
Maybe it's worth to drop it: bazelbuild/rules_cc#283

@mergify mergify bot removed the merge-queue merge on green CI label Nov 28, 2024
@malt3
Copy link
Collaborator

malt3 commented Nov 28, 2024

Thanks for the pointer. As you pointed out, upgrading rules_cc is not a trivial change in rules_nixpkgs at this point, so your PR is still good for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

almost all of @bazel_tools//tools/cpp may not exist for [email protected]
3 participants