Exclusive profiling mode #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profiling mode is active (`compilation_mode == "dbg"`) then we compile only profiling libraries and binaries instead of compiling both. The toolchain libraries then only carry their static archives, as profiling mode doesn't provide any shared libraries. Some test cases strictly require shared objects. Those are disabled in profiling mode.
If suffix was empty the returned library name would be empty, causing linker errors down the line.
Bazel does not allow nested select statements. It also doesn't allow ambiguous select statements. With the custom `fastbuild_(windows|darwin)` conditions there would be ambiguity between `:debug_build` and `windows|darwin` if `-c dbg` is set.
|
CI is green now. The handling of |
mboes
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #895
compilation_mode == "dbg") then we compile only profiling libraries and binaries instead of compiling both profiling and non-profiling. In profiling mode the toolchain libraries only carry their static archives, as profiling mode doesn't provide any shared libraries.Wrt. #438 this PR goes further down the road of
-fexternal-interpreter. Given the large performance penalty that that implies we may yet want to compile non-profiling objects for GHCi/Template Haskell. However, as mentioned in #895 it seems better to not expose these in theCcInfoprovider, but instead handle them separately inHaskellInfo.