Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends repl flags with compiler_flags #334

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Extends repl flags with compiler_flags #334

merged 2 commits into from
Jul 16, 2018

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Jul 14, 2018 •
edited
Loading

Closes #331.

  • compiler_flags attributes from haskell_toolchain and haskell_binary or haskell_library are now used for repl. Rational: users usually set GHC options such as the list of used extensions in compiler_flags. By default, REPL targets must behaves as compiled versions. Users can still override compiler_flags by providing repl_ghci_flags.
  • repl_ghci_flags is now also available in haskell_toolchain to enable global setting.

@guibou guibou requested review from mboes and mrkkrp July 14, 2018 14:06
@guibou guibou changed the title Guibou/repl flags Extends repl flags with compiler_flags Jul 14, 2018
@guibou guibou merged commit 4c7d7c7 into master Jul 16, 2018
@guibou guibou deleted the guibou/repl_flags branch July 16, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes mboes approved these changes

@mrkkrp mrkkrp mrkkrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guibou @mboes @mrkkrp