Fix using the single threaded RTS lib #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GHC 9.4.1, the rts library has `hs-libraries: HSrts-1.0.2 Cffi` in the package config. We have special handling for HSrts (and Cffi) but that fails due to the name change.
avdv
force-pushed
the
cb/fix-threaded-so-symlink
branch
from
9f7ae19 to
4e7d45d
Compare
According to the cabal docs, the `hs-libraries` entries of a package config needs to comply to specific file naming conventions, see [1]. Only names starting with `HS` or `C` are allowed and dynamic libs prefixed with `C` need to be handled specially as the "C" prefix should be stripped. The "rts" hs-libraries also exist in all configured GHC ways, single/multi threaded and debug/non-debug variants. Before, only rts's Cffi was handled correctly but other C libs were not. [1]: https://cabal.readthedocs.io/en/3.4/cabal-package.html#pkg-field-extra-bundled-libraries
avdv
force-pushed
the
cb/fix-threaded-so-symlink
branch
from
4e7d45d to
ea41a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GHC 9.4.1, the rts package has
hs-libraries: HSrts-1.0.2 Cffiin its package config.We have special handling for HSrts (and Cffi) but that fails due to the name change.
This caused the build on Bazel CI to fail since the single threaded rts library
was symlinked into the solib directory instead of the multi threaded variant:
Fixes #2188
Note: Bazel CI is green on this branch: https://buildkite.com/bazel/rules-haskell-haskell/builds/2032