Reorganize tests #22
Merged
Reorganize tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects that need cpphs are by now extremely rare. `jni` does use it, but `jni` can be changed to no need any particular build system support for that. In fact here's a PR demonstrating that: tweag/inline-java#100. So culling cpphs support. Less code to maintain.
Use `rule_test` to verify that a rule a) worked, b) produced the expected output. This obviates the need for a shell script that launches binaries and is more general, so can be used systematically. It's the testing strategy that `rules_rust` uses. We may want to revive launching binaries later, but this is good enough for now. Also, systematically put each test in its own subdir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
rule_testto verify that a rule a) worked, b) produced theexpected output. This obviates the need for a shell script that
launches binaries and is more general, so can be used systematically.
It's the testing strategy that
rules_rustuses. We may want torevive launching binaries later, but this is good enough for now.
Also, systematically put each test in its own subdir.